Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15314#discussion_r82083135
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -1014,7 +1014,7 @@ class LinearRegressionSuite
checkModelData)
}
- test("should support all NumericType labels and not support other
types") {
+ test("should support all NumericType labels and weights and not support
other types") {
--- End diff --
When I made changes to actually test weights, I had to adjust the equality
functions to use approx equals. Maybe `absTol 1e-6` is reasonable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
