Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13868#discussion_r82154809
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -55,7 +56,7 @@ object SQLConf {
val WAREHOUSE_PATH = SQLConfigBuilder("spark.sql.warehouse.dir")
.doc("The default location for managed databases and tables.")
.stringConf
- .createWithDefault("file:${system:user.dir}/spark-warehouse")
+ .createWithDefault("${system:user.dir}/spark-warehouse")
--- End diff --
@avulanov can I call on your expertise here? @koertkuipers and I noticed
that this causes a problem, in that this path intends to be a local file system
path in the local home dir, but will now be interpreted as a path on HDFS for
HDFS deployments.
If this is intended to be a local path always, and it seems like it is,
then the usages of the new `makeQualifiedPath` are a bit wrong in that they
explicitly resolve the path against the Hadoop file system, which can be HDFS.
Alternatively, just removing `user.dir` kind of works too, in that it will
at least become a path relative to the HDFS user dir I think. Do you know which
is better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
