Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15354#discussion_r82230165
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -1729,6 +1729,29 @@ def from_json(col, schema, options={}):
         return Column(jc)
     
     
    +@ignore_unicode_prefix
    +@since(2.1)
    +def to_json(col, options={}):
    +    """
    +    Converts a column containing a [[StructType]] into a JSON string. 
Returns `null`,
    +    in the case of an unsupported type.
    +
    +    :param col: struct column
    --- End diff --
    
    Would    `:param col: name of column containing the struct` maybe be more 
consistent with the other pydocs for the functions? (I only skimmed a few 
though so if its the other way around thats cool).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to