Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15370#discussion_r82253107
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -71,6 +72,12 @@ private[spark] object CallSite {
private[spark] object Utils extends Logging {
val random = new Random()
+ // Use a common file numbering format which defaults to 5 digits for
saving various part files.
+ val numFormatter = NumberFormat.getIntegerInstance()
+ numFormatter.setMinimumIntegerDigits(5)
+ numFormatter.setMaximumIntegerDigits(10)
--- End diff --
I don't think we really need to set the max. Every place this is used we
pass an id in that is already restricted to an int. If we did happen to change
those other interfaces to take say a long this would then break again. I'm
thinking we should just remove.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
