Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15379#discussion_r82315908
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -289,8 +289,8 @@ def text(self, paths):
[Row(value=u'hello'), Row(value=u'this')]
"""
if isinstance(paths, basestring):
- path = [paths]
- return
self._df(self._jreader.text(self._spark._sc._jvm.PythonUtils.toSeq(path)))
+ paths = [paths]
+ return
self._df(self._jreader.text(self._spark._sc._jvm.PythonUtils.toSeq(paths)))
--- End diff --
This is a super minor but I think it'd be nicer to match up the variable
name to `path` if this makes sense. For parquet, it takes non-keyword arguments
so it seems `paths` but for others, it seems take a single argument.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
