Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15292#discussion_r82333056
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -17,47 +17,130 @@
package org.apache.spark.sql.execution.datasources.jdbc
+import java.sql.{Connection, DriverManager}
+import java.util.Properties
+
/**
* Options for the JDBC data source.
*/
class JDBCOptions(
@transient private val parameters: Map[String, String])
extends Serializable {
+ import JDBCOptions._
+
+ def this(url: String, table: String, parameters: Map[String, String]) = {
+ this(parameters ++ Map("url" -> url, "dbtable" -> table))
+ }
+
+ val asProperties: Properties = {
--- End diff --
Sounds good but it seems both are fine as actual class name is `Properties`
but I guess the meaning is connection properties. Maybe this one depends on
personal taste.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
