Github user tgravescs commented on the issue:

    https://github.com/apache/spark/pull/15370
  
    I don't consider this complex, its simply one number formatter and you say 
get.   Padding to 10 digits isn't necessary in 99% of the cases, so you are 
just using longer file strings and more digits if its always 10.
    
    Also if you use the number formatter in the other cases you don't have to 
worry about breaking backwards compatibility.  It still uses 5 digits up until 
you would really need.
    
    I think we should leave this as number formatter.  I also think if we are 
using it for all the part file formatting leaving in utils makes sense.  We 
could rename it slightly to make it more apparent about its usage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to