Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15371#discussion_r82559538
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -55,7 +55,11 @@ object MimaExcludes {
           
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.getFunction"),
           
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.databaseExists"),
           
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.tableExists"),
    -      
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.functionExists")
    +      
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.functionExists"),
    +      // [SPARK-17816] Fix ConcurrentModificationException issue in 
BlockStatusesAccumulator
    +      
ProblemFilters.exclude[DirectAbstractMethodProblem]("org.apache.spark.util.AccumulatorV2.merge"),
    --- End diff --
    
    Hm, but this class didn't have any change in its API, not at this point. I 
can't see why it would still be needed. In fact there's a merge conflict here 
anyway, can you just try removing it and see if it passes?
    
    Looking strong to me otherwise, great cleanup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to