GitHub user invkrh opened a pull request:

    https://github.com/apache/spark/pull/15420

    Remove query string from jar url

    ## What changes were proposed in this pull request?
    
    Spark-submit support jar url with http protocol. However, if the url 
contains any query strings, `worker.DriverRunner.downloadUserJar()` method will 
throw "Did not see expected jar" exception. This is because this method checks 
the existance of a downloaded jar whose name contains query strings. This is a 
problem when your jar is located on some web service which requires some 
additional information to retrieve the file.
    
    This pr just removes query strings before checking jar existance on worker.
    
    ## How was this patch tested?
    
    For now, you can only test this patch by manual test.
    * Deploy a spark cluster locally
    * Make sure apache httpd service is on
    * Save an uber jar, e.g spark-job.jar under `/var/www/html/`
    * Use http://localhost/spark-job.jar?param=1 as jar url when running 
`spark-submit`
    * Job should be launched
    
    
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/invkrh/spark spark-17855

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15420.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15420
    
----
commit ef308acb02e11bdbad4d3dcf34460d1739f16f58
Author: invkrh <inv...@gmail.com>
Date:   2016-10-10T13:25:11Z

    Remove query string from jar url

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to