Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r82737073
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2374,14 +2374,14 @@ object functions {
* @group datetime_funcs
* @since 1.5.0
*/
- def date_add(start: Column, days: Int): Column = withExpr {
DateAdd(start.expr, Literal(days)) }
+ def date_add(start: Column, days: Int): Column = withExpr {
AddDays(start.expr, Literal(days)) }
--- End diff --
I don't get what you were suggesting here. Wouldn't it make more sense to
make DateAdd expression support both adding Interval type and adding
IntegralType (for days)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
