Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/15307#discussion_r82890465
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -105,11 +105,21 @@ class StreamExecution(
var lastExecution: QueryExecution = null
@volatile
- var streamDeathCause: StreamingQueryException = null
+ private var streamDeathCause: StreamingQueryException = null
/* Get the call site in the caller thread; will pass this into the micro
batch thread */
private val callSite = Utils.getCallSite()
+ /** Metrics for this query */
+ private val streamMetrics =
+ new StreamMetrics(uniqueSources.toSet, triggerClock,
s"StructuredStreaming.$name")
--- End diff --
makes sense. Since metrics are updated in the execution thread and not the
listener bus, there can't be old data suddenly updating the metrics right after
a stream is stopped?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
