Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15414#discussion_r82932894
--- Diff: mllib/src/test/scala/org/apache/spark/ml/PredictorSuite.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ml
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.ml.linalg._
+import org.apache.spark.ml.param.ParamMap
+import org.apache.spark.ml.util._
+import org.apache.spark.mllib.util.MLlibTestSparkContext
+import org.apache.spark.sql.{DataFrame, Dataset}
+import org.apache.spark.sql.types._
+
+class PredictorSuite extends SparkFunSuite with MLlibTestSparkContext with
DefaultReadWriteTest {
+
+ import testImplicits._
+
+ class MockPredictor(override val uid: String)
+ extends Predictor[Vector, MockPredictor, MockPredictionModel] {
+
+ override def train(dataset: Dataset[_]): MockPredictionModel = {
+ require(dataset.schema("label").dataType == DoubleType)
+ new MockPredictionModel(uid)
+ }
+
+ override def copy(extra: ParamMap): MockPredictor = defaultCopy(extra)
+ }
+
+ class MockPredictionModel(override val uid: String)
+ extends PredictionModel[Vector, MockPredictionModel] {
+
+ override def predict(features: Vector): Double = 1.0
+
+ override def copy(extra: ParamMap): MockPredictionModel =
defaultCopy(extra)
+ }
+
+ test("should support all NumericType labels and not support other
types") {
+ val predictor = new MockPredictor("mock")
+ MLTestingUtils.checkNumericTypes[MockPredictionModel, MockPredictor](
--- End diff --
Why don't we just cycle through the types here and call `fit`. I think it's
a bit confusing the way it is now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
