Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15427
My thoughts:
1. `Dataset.dropDuplicates()` should drop duplicates for all columns, the
current implementation is wrong, this PR fixed it.
2. `Dataset.dropDuplicates(col: String)` should drop the first column
matching the given name, or all matched columns? `Dataset.drop(col: String)`
also drops all matched columns, the new behaviour seems reasonable. But we
should be very careful, as this is a breaking change. cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
