Github user drcrallen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13713#discussion_r83112712
  
    --- Diff: 
mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala
 ---
    @@ -463,6 +463,21 @@ class MesosCoarseGrainedSchedulerBackendSuite extends 
SparkFunSuite
         assert(launchedTasks.head.getCommand.getUrisList.asScala(0).getValue 
== url)
       }
     
    +  test("mesos supports setting fetcher cache") {
    +    val url = "spark.spark.spark.com"
    +    setBackend(Map(
    +      "spark.mesos.fetchCache.enable" -> "true",
    +      "spark.executor.uri" -> url
    +    ), false)
    +    val offers = List(Resources(backend.executorMemory(sc), 1))
    +    offerResources(offers)
    +    // Don't crash!
    --- End diff --
    
    it originally didn't do much except check that it didn't fail. I have since 
added proper checking of the task info for if the fetcher cache was enabled. 
Will remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to