GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/15467
[SPARK-17192][SQL] Refactor code generation to get data for ColumnVector/ColumnarBatch ## What changes were proposed in this pull request? This PR refactors the code generation part to get data from `ColumnarVector` and `ColumnarBatch` by using a trait `ColumnarBatchScan` for ease of reuse. This is because this part will be reused by several components (e.g. parquet reader, Dataset.cache, and others) since `ColumnarBatch` will be first citizen. This PR is a part of https://github.com/apache/spark/pull/15219. In advance, this PR makes the code generation for `ColumnarVector` and `ColumnarBatch` reuseable as a trait. In general, this is very useful for other components from the reuseability view, too. ## How was this patch tested? tested existing test suites You can merge this pull request into a Git repository by running: $ git pull https://github.com/kiszk/spark columnarrefactor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/15467.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15467 ---- commit 5d78d012758d18bb76f0cd76a58145f8ff99f525 Author: Kazuaki Ishizaki <ishiz...@jp.ibm.com> Date: 2016-10-13T16:02:53Z refactoring ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org