Github user avulanov commented on a diff in the pull request:
https://github.com/apache/spark/pull/15382#discussion_r83346125
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -757,7 +758,10 @@ private[sql] class SQLConf extends Serializable with
CatalystConf with Logging {
def variableSubstituteDepth: Int = getConf(VARIABLE_SUBSTITUTE_DEPTH)
- def warehousePath: String = new Path(getConf(WAREHOUSE_PATH)).toString
+ def warehousePath: String = {
+ val path = new Path(getConf(WAREHOUSE_PATH))
+ FileSystem.get(path.toUri, new
Configuration()).makeQualified(path).toString
--- End diff --
`resolveURI` function does not process correctly some of the inputs (even
some Linux paths). It contains a bug and should be fixed. The name itself is a
bit misleading, because it processes `String` rather than `URI`, and is capable
of resolving Paths. I propose to rename it to `resolvePath`, and rewrite it
according to its documentation (below). Then we can use it to fix the initial
issue. Does it sound reasonable to you?
```
/**
* Return a well-formed URI for the file described by a user input string.
*
* If the supplied path does not contain a scheme, or is a relative path,
it will be
* converted into an absolute path with a file:// scheme.
*/
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
