Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14690#discussion_r83348167
--- Diff:
core/src/main/scala/org/apache/spark/metrics/source/StaticSources.scala ---
@@ -60,3 +60,32 @@ object CodegenMetrics extends Source {
val METRIC_GENERATED_METHOD_BYTECODE_SIZE =
metricRegistry.histogram(MetricRegistry.name("generatedMethodSize"))
}
+
+/**
+ * :: Experimental ::
+ * Metrics for access to the hive external catalog.
+ */
+@Experimental
+object HiveCatalogMetrics extends Source {
+ override val sourceName: String = "HiveExternalCatalog"
+ override val metricRegistry: MetricRegistry = new MetricRegistry()
+
+ /**
+ * Tracks the total number of partition metadata entries fetched via the
client api.
+ */
+ val METRIC_PARTITIONS_FETCHED =
metricRegistry.counter(MetricRegistry.name("partitionsFetched"))
+
+ /**
+ * Tracks the total number of files discovered off of the filesystem by
ListingFileCatalog.
+ */
+ val METRIC_FILES_DISCOVERED =
metricRegistry.counter(MetricRegistry.name("filesDiscovered"))
+
+ def reset(): Unit = {
+ METRIC_PARTITIONS_FETCHED.dec(METRIC_PARTITIONS_FETCHED.getCount())
+ METRIC_FILES_DISCOVERED.dec(METRIC_FILES_DISCOVERED.getCount())
+ }
+
+ // clients can use these to avoid classloader issues with the codahale
classes
--- End diff --
I don't quite understand the issue, but if you reference the Counter object
directly from the caller sites then you get
```
[info] Exception encountered when attempting to run a suite with class
name: org.apache.spark.sql.hive.HiveDataFrameSuite *** ABORTED *** (12 seconds,
51 milliseconds)
[info] java.lang.LinkageError: loader constraint violation: loader
(instance of org/apache/spark/sql/hive/client/IsolatedClientLoader$$anon$1)
previously initiated loading for a different type with name
"com/codahale/metrics/Counter"
[info] at java.lang.ClassLoader.defineClass1(Native Method)
[info] at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
[info] at
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
[info] at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
