GitHub user ajbozarth opened a pull request:
https://github.com/apache/spark/pull/15490
[SPARK-10541] [Web UI] Allow ApplicationHistoryProviders to provide their
own text when there aren't any complete apps
## What changes were proposed in this pull request?
I've added a method to `ApplicationHistoryProvider` that returns the html
paragraph to display when there are no applications. This allows providers
other than `FsHistoryProvider` to determine what is printed. The current hard
coded text is now moved into `FsHistoryProvider` since it assumed that's what
was being used before.
I chose to make the function return html rather than text because the
current text block had inline html in it and it allows a new implementation of
`ApplicationHistoryProvider` more versatility. I did not see any security
issues with this since injecting html here requires implementing
`ApplicationHistoryProvider` and can't be done outside of code.
## How was this patch tested?
Manual testing and dev/run-tests
No visible changes to the UI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajbozarth/spark spark10541
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15490
----
commit a343a08a65d871b6f64b3df392741e7f0773cb25
Author: Alex Bozarth <ajboz...@us.ibm.com>
Date: 2016-10-14T00:49:41Z
Moved the html text displayed on an empty app list into a method in the
provider
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
