Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15432
I see. That makes perfect sense in general. It is good to improve test
coverage. Though, we might have to avoid adding test cases here and there when
there are obviously no side-effect. Running tests already takes few hours.
At least, I am trying to submit a PR as sensible as I can, considering all
the comments I received before, re-reading documentation and referring other
good PRs. I left some comments above because it seems usually not or not like
what I was told before (at least in my experience).
Maybe we should mention it somewhere like wiki and make this official
because I guess others might have a very different view for this. We may say,
"please at least run them manually and then include the results in the PR
description".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
