Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15285#discussion_r83742279
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/ui/LogPage.scala ---
@@ -115,6 +117,19 @@ private[ui] class LogPage(parent: WorkerWebUI) extends
WebUIPage("logPage") with
UIUtils.basicSparkPage(content, logType + " log page for " + pageName)
}
+ private val fileUncompressedLengthCacheSize = parent.worker.conf.getInt(
+ RollingFileAppender.FILE_UNCOMPRESSED_LENGTH_CACHE_SIZE,
+ RollingFileAppender.DEFAULT_FILE_UNCOMPRESSED_LENGTH_CACHE_SIZE)
+ // Cache the file size, since it is expensive to compute the
uncompressed file size.
+ private val fileUncompressedLengthCache = CacheBuilder.newBuilder()
+ .maximumSize(fileUncompressedLengthCacheSize)
+ .build[String, java.lang.Long](new CacheLoader[String,
java.lang.Long]() {
+ override def load(path: String): java.lang.Long = {
+ Utils.getFileLength(new File(path))
--- End diff --
I just learnt that CacheLoad.load has issues with obfuscating exception. So
I think what may happen is that if Utils.getFileLength throws any exception, it
will be wrapped and rethrown by Guava with a different stack trace, thus making
it very confusing. I strongly suggest adding try catch here to log stuff (as
warning) before rethrowing the same exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
