Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/13775#discussion_r83763831
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -118,6 +120,11 @@ class OrcFileFormat extends FileFormat with
DataSourceRegister with Serializable
val broadcastedHadoopConf =
sparkSession.sparkContext.broadcast(new
SerializableConfiguration(hadoopConf))
+ val enableVectorizedReader: Boolean =
+ sparkSession.sessionState.conf.orcVectorizedReaderEnabled &&
+ dataSchema.forall(f => f.dataType.isInstanceOf[AtomicType] &&
--- End diff --
This is not reliable. If a new `AtomicType` type gets introduced and not
supported for vectorised reads, this will not guard us against that. Its easy
for anyone to forget to add new atomic type to the exclusion list in this check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
