Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15551#discussion_r84020848
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriteOutput.scala
---
@@ -0,0 +1,478 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources
+
+import java.util.{Date, UUID}
+
+import org.apache.hadoop.conf.Configuration
+import org.apache.hadoop.fs.Path
+import org.apache.hadoop.mapreduce._
+import org.apache.hadoop.mapreduce.lib.output.{FileOutputCommitter =>
MapReduceFileOutputCommitter}
+import org.apache.hadoop.mapreduce.task.TaskAttemptContextImpl
+
+import org.apache.spark._
+import org.apache.spark.internal.Logging
+import org.apache.spark.mapred.SparkHadoopMapRedUtil
+import org.apache.spark.sql.{Dataset, SparkSession}
+import org.apache.spark.sql.catalyst.catalog.BucketSpec
+import org.apache.spark.sql.catalyst.expressions._
+import org.apache.spark.sql.catalyst.plans.physical.HashPartitioning
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
+import org.apache.spark.sql.execution.{SQLExecution,
UnsafeKVExternalSorter}
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.types.{IntegerType, StringType, StructField,
StructType}
+import org.apache.spark.util.{SerializableConfiguration, Utils}
+import org.apache.spark.util.collection.unsafe.sort.UnsafeExternalSorter
+
+
+/**
+ * A helper object for writing data out to an existing partition. This is
a work-in-progress
+ * refactoring. The goal is to eventually remove the class hierarchy in
WriterContainer.
+ */
+object WriteOutput extends Logging {
+
+ def write(
+ sparkSession: SparkSession,
+ plan: LogicalPlan,
+ fileFormat: FileFormat,
+ outputPath: Path,
+ hadoopConf: Configuration,
+ partitionColumns: Seq[Attribute],
+ bucketSpec: Option[BucketSpec],
+ refreshFunction: () => Unit,
+ options: Map[String, String],
+ isAppend: Boolean): Unit = {
+
+ val job = Job.getInstance(hadoopConf)
+ job.setOutputKeyClass(classOf[Void])
+ job.setOutputValueClass(classOf[InternalRow])
+
+ val partitionSet = AttributeSet(partitionColumns)
+ val dataColumns = plan.output.filterNot(partitionSet.contains)
+ val queryExecution = Dataset.ofRows(sparkSession, plan).queryExecution
+
+ // Note: prepareWrite has side effect. It sets "job".
+ val outputWriterFactory =
+ fileFormat.prepareWrite(sparkSession, job, options,
dataColumns.toStructType)
+
+ val context = new WriteJobDescription(
+ outputWriterFactory = outputWriterFactory,
+ allColumns = plan.output,
+ partitionColumns = partitionColumns,
+ nonPartitionColumns = dataColumns,
+ isAppend = isAppend,
+ path = outputPath,
+ outputFormatClass = job.getOutputFormatClass,
+ bucketSpec = bucketSpec)
+
+ val serializableHadoopConf = new SerializableConfiguration(hadoopConf)
+
+ SQLExecution.withNewExecutionId(sparkSession, queryExecution) {
+
+ // This call shouldn't be put into the `try` block below because it
only initializes and
+ // prepares the job, any exception thrown from here shouldn't cause
abortJob() to be called.
+ val committer = setupDriverCommitter(hadoopConf, job, outputPath,
isAppend)
+
+ try {
+ sparkSession.sparkContext.runJob(queryExecution.toRdd,
+ (taskContext: TaskContext, iter: Iterator[InternalRow]) => {
+ executeTask(context, serializableHadoopConf.value,
taskContext, iter)
+ })
+
+ committer.commitJob(job)
+ logInfo(s"Job ${job.getJobID} committed.")
+
+ refreshFunction()
+ } catch { case cause: Throwable =>
+ logError(s"Aborting job ${job.getJobID}.", cause)
+ committer.abortJob(job, JobStatus.State.FAILED)
+
+ throw new SparkException("Job aborted.", cause)
+ }
+ }
+ }
+
+ class WriteJobDescription(
+ val outputWriterFactory: OutputWriterFactory,
+ val allColumns: Seq[Attribute],
+ val partitionColumns: Seq[Attribute],
+ val nonPartitionColumns: Seq[Attribute],
+ val isAppend: Boolean,
+ val path: Path,
+ val outputFormatClass: Class[_ <: OutputFormat[_, _]],
+ val bucketSpec: Option[BucketSpec])
+ extends Serializable
+
+ def executeTask(
+ description: WriteJobDescription,
+ hadoopConf: Configuration,
+ taskContext: TaskContext,
+ iterator: Iterator[InternalRow]): Unit = {
+ // Setup IDs
+ val jobId = SparkHadoopWriter.createJobID(new Date,
taskContext.stageId())
+ val taskId = new TaskID(jobId, TaskType.MAP, taskContext.partitionId())
+ val taskAttemptId = new TaskAttemptID(taskId,
taskContext.attemptNumber())
+
+ // Set up the configuration object
+ hadoopConf.set("mapred.job.id", jobId.toString)
+ hadoopConf.set("mapred.tip.id", taskAttemptId.getTaskID.toString)
+ hadoopConf.set("mapred.task.id", taskAttemptId.toString)
+ hadoopConf.setBoolean("mapred.task.is.map", true)
+ hadoopConf.setInt("mapred.task.partition", 0)
+
+ val taskAttemptContext = new TaskAttemptContextImpl(hadoopConf,
taskAttemptId)
+ val committer = newOutputCommitter(
+ description.outputFormatClass, taskAttemptContext, description.path,
description.isAppend)
+ committer.setupTask(taskAttemptContext)
+
+ if (description.partitionColumns.isEmpty &&
description.bucketSpec.isEmpty) {
--- End diff --
Now we will run this if-else at executor side right? Not a big deal, and
worth it to make the code simpler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
