Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15463#discussion_r84139585
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -974,6 +974,22 @@ class TaskSetManagerSuite extends SparkFunSuite with
LocalSparkContext with Logg
assert(manager.isZombie)
}
+ test("check uniqueness of TaskSetManager name") {
+ sc = new SparkContext("local", "test")
+ sched = new FakeTaskScheduler(sc, ("exec1", "host1"))
+ val taskSet = FakeTask.createTaskSet(1, 0, 0)
+ val manager = new TaskSetManager(sched, taskSet, MAX_TASK_FAILURES,
new ManualClock)
+ assert(manager.name === "TaskSet_0.0")
+
--- End diff --
Can you add a comment about what's going on in this chunk -- something like
"Make sure a task set for the same stage (but a different attempt) has a
different ID"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
