Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15377#discussion_r84212380
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2432,6 +2432,26 @@ private[spark] object Utils extends Logging {
       }
     }
     
    +private[util] object CallerContext {
    +  private def callerContextClassExists(): Boolean = {
    +    try {
    +      // scalastyle:off classforname
    +      Class.forName("org.apache.hadoop.ipc.CallerContext")
    +      Class.forName("org.apache.hadoop.ipc.CallerContext$Builder")
    +      // scalastyle:on classforname
    +      true
    +    } catch {
    +      case _ : ClassNotFoundException => false
    +    }
    +  }
    --- End diff --
    
    The above code can be simplified with `Try { xxxx }.isSuccess`, please 
check `scala.util.Try`. Then these two methods can be merged into one 
expression.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to