Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15513#discussion_r84406453
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/MonotonicallyIncreasingID.scala
 ---
    @@ -33,13 +33,20 @@ import org.apache.spark.sql.types.{DataType, LongType}
      * Since this expression is stateful, it cannot be a case object.
      */
     @ExpressionDescription(
    -  usage =
    -    """_FUNC_() - Returns monotonically increasing 64-bit integers.
    +  usage = """
    +    _FUNC_() - Returns monotonically increasing 64-bit integers.
           The generated ID is guaranteed to be monotonically increasing and 
unique, but not consecutive.
           The current implementation puts the partition ID in the upper 31 
bits, and the lower 33 bits
           represent the record number within each partition. The assumption is 
that the data frame has
    -      less than 1 billion partitions, and each partition has less than 8 
billion records.""",
    -  extended = "> SELECT _FUNC_();\n 0")
    +      less than 1 billion partitions, and each partition has less than 8 
billion records.
    +  """,
    +  extended = """
    +    _FUNC_()
    +
    +      Examples:
    +        > SELECT _FUNC_();
    --- End diff --
    
    this example is fairly useless so I'd just remove it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to