Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15539#discussion_r84424418
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/TableFileCatalog.scala
---
@@ -42,24 +43,21 @@ class TableFileCatalog(
protected val hadoopConf = sparkSession.sessionState.newHadoopConf
+ private val fileStatusCache = FileStatusCache.getOrInitializeShared(new
Object(), sparkSession)
--- End diff --
The way we currently refresh tables is by dropping the reference to
TableFileCatalog and letting it get GC'ed. Given this strategy, making it
private is the simplest way to ensure refresh actually works correctly --
otherwise you have to carefully test that refresh also invalidates shared cache
entries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
