Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/1750#discussion_r16815625
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -935,6 +936,7 @@ private[hive] object HiveQl {
case Token(DIV(), left :: right:: Nil) =>
Cast(Divide(nodeToExpr(left), nodeToExpr(right)), LongType)
case Token("%", left :: right:: Nil) => Remainder(nodeToExpr(left),
nodeToExpr(right))
+ case Token("TOK_FUNCTION", Token(SQRT(), Nil) :: arg :: Nil) =>
Sqrt(nodeToExpr(arg))
--- End diff --
Hey @liancheng, I agree that it is possible to special-case this function
(and can certainly do so for this PR). I recently [wrote up what Hive
does](http://chapeau.freevariable.com/2014/08/existing-system-coercion.html)
and have some work in progress on a more general solution that should capture
what Hive does.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
