Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14957#discussion_r84558190 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -126,4 +136,52 @@ object FileSourceStrategy extends Strategy with Logging { case _ => Nil } + + private def generateStructFieldsContainsNesting(projects: Seq[Expression], + totalSchema: StructType) : Seq[StructField] = { --- End diff -- Would you please add comments and test cases for testing this method, which is basically the essential part of this PR?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org