Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12913#discussion_r84570736
  
    --- Diff: 
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
    @@ -186,9 +193,15 @@ class KryoSerializer(conf: SparkConf)
     private[spark]
     class KryoSerializationStream(
         serInstance: KryoSerializerInstance,
    -    outStream: OutputStream) extends SerializationStream {
    +    outStream: OutputStream,
    +    useUnsafe: Boolean) extends SerializationStream {
     
    -  private[this] var output: KryoOutput = new KryoOutput(outStream)
    +  private[this] var output: KryoOutput =
    +    if (useUnsafe) {
    --- End diff --
    
    put this in one line?
    ```
        if (useUnsafe) new KryoUnsafeOutput(outStream) else new 
KryoOutput(outStream)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to