Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15595#discussion_r84590334
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
 ---
    @@ -377,4 +377,14 @@ class AnalysisSuite extends AnalysisTest {
         assertExpressionType(sum(Divide(Decimal(1), 2.0)), DoubleType)
         assertExpressionType(sum(Divide(1.0, Decimal(2.0))), DoubleType)
       }
    +
    +
    +  test("SPARK-18058: union operations shall not care about the nullability 
of columns") {
    --- End diff --
    
    +1 (actually, it'd be nicer if it has unit test and end-to-end test).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to