Github user yinxusen commented on the issue:
https://github.com/apache/spark/pull/11119
How about the following:
1. Since the new generated model is derived from an estimator, the model
should have the same params as its parent estimator. That's why there is no
need to consider about params of model. We can only care about params of the
estimator, as we have already done in the code - the param k and param initMode.
2. We can treat initialModel as a "transient" variable so that it must be
vanished facing serialization, since there is no need to hold initialModel in a
new generated model.
3. We can introduce a dumb model as a placeholder for initialModel, as a
consequence, users know the initialization method of the model.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
