Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15596#discussion_r84838595
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
 ---
    @@ -298,6 +298,12 @@ case class WholeStageCodegenExec(child: SparkPlan) 
extends UnaryExecNode with Co
       override def outputPartitioning: Partitioning = child.outputPartitioning
     
       override def outputOrdering: Seq[SortOrder] = child.outputOrdering
    +  override def executeCollect(): Array[InternalRow] = child match {
    +    // This happens when the user is collecting results back to the 
driver, we could skip
    +    // the shuffling and scan increasingly the RDD to get the limited 
items.
    +    case g: GlobalLimitExec => g.executeCollect()
    --- End diff --
    
    this is really confusing ...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to