GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/15647
[SPARK-18088][ML] Various ChiSqSelector cleanups
## What changes were proposed in this pull request?
* Renamed kbest to numTopFeatures
* Renamed alpha to fpr
* Added missing Since annotations
* Doc cleanups
## How was this patch tested?
Added new standardized unit tests for spark.ml.
Improved existing unit test coverage a bit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkbradley/spark chisqselector-follow-ups
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15647.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15647
----
commit 10f8b263d295273f14443cc32064b413035fd195
Author: Joseph K. Bradley <jos...@databricks.com>
Date: 2016-10-26T17:16:05Z
Various ChiSqSelector cleanups:
* Renamed kbest to numTopFeatures
* Renamed alpha to fpr
* Added missing Since annotations
* Doc cleanups
* Added missing standard unit tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
