Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15513
Thanks @gatorsmile. Just FYI, I would like to note the rule I used for
argument types (just to avoid extra efforts when you review).
As we all know, I did not mention implicit casting as suggested. So, I kind
of tired the best efforts to describe this by using the abstract terms for
types such as `numeric` or `integral` which are borrowed from the actual class
names such as `NumericType` or `IntegralType` where possible. When it is not
possible, I noted the original type as each function requires.
For example, If a function takes `integer literal` as the argument but
allows implicit casting,
I noted it as `numeric literal` because other numeric literals such as
`1BD`, `1.0`, `1` and `1L` are allowed (but note that string literal `"1"` is
also allowed).
Another reason why I used this rule is, for the potential documentation
update to mention implicit casting in the future. For example,
```
a numeric expression.
```
would be easily updated as below:
```
a numeric expression and any non-numeric types that can be implicitly
casted to a numeric expression.
```
Another example would be..
```
a timestamp expression.
```
would be easily updated as below:
```
a timestamp expression and any types that can be implicitly casted to a
timestamp expression.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
