Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15659#discussion_r85507910
  
    --- Diff: bin/spark-shell ---
    @@ -29,7 +29,7 @@ esac
     set -o posix
     
     if [ -z "${SPARK_HOME}" ]; then
    -  export SPARK_HOME="$(cd "`dirname "$0"`"/..; pwd)"
    +  source `dirname $0`/find-spark-home
    --- End diff --
    
    So for pip installed PySpark we need to do a bit more work to find the 
SPARK_HOME, using a common script to determine if we need to do more hunting 
rather than duplicating the logic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to