Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85602891
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -44,9 +45,14 @@ import org.apache.spark.util.UninterruptibleThread
* Note: [[HDFSMetadataLog]] doesn't support S3-like file systems as they
don't guarantee listing
* files in a directory always shows the latest files.
*/
-class HDFSMetadataLog[T: ClassTag](sparkSession: SparkSession, path:
String)
+class HDFSMetadataLog[T <: AnyRef : ClassTag](sparkSession: SparkSession,
path: String)
extends MetadataLog[T] with Logging {
+ private implicit val formats = Serialization.formats(NoTypeHints)
+
+ /** Needed to serialize type T into JSON */
+ private implicit val manifest =
Manifest.classType[T](implicitly[ClassTag[T]].runtimeClass)
--- End diff --
Why is this needed now? This wasnt needed earlier when we were using json
serialization in FilestreamSinkLog, then why is the manifest needed now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
