Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15677#discussion_r85635839
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -148,8 +171,15 @@ case class Hour(child: Expression) extends
UnaryExpression with ImplicitCastInpu
}
@ExpressionDescription(
- usage = "_FUNC_(param) - Returns the minute component of the
string/timestamp/interval.",
- extended = "> SELECT _FUNC_('2009-07-30 12:58:59');\n 58")
+ usage = "_FUNC_(timestamp) - Returns the minute component of the
string/timestamp.",
+ extended = """
+ Arguments:
+ timestamp - a timestamp expression.
--- End diff --
Oh, yes. I knew this but I was hesitant to fix `string/timestamp` because
fixing this to `timestamp` sounds a (strictly..) regression in the
documentation (it mean, `string/timestamp` is not inaccurate..); however, I
also could not add `string` in `extended` part as it is inconsistent with the
others.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
