GitHub user mrydzy opened a pull request:
https://github.com/apache/spark/pull/15687
Update SparkPi.scala
## What changes were proposed in this pull request?
If my understanding is correct we should be rather looking at closed disk
than the opened one.
## How was this patch tested?
Run simple comparison, of the mean squared error of approaches with closed
and opened disk.
https://gist.github.com/mrydzy/1cf0e5c316ef9d6fbd91426b91f1969f
The closed one performed slightly better, but the tested sample wasn't too
big, so I rely mostly on the algorithm understanding.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mrydzy/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15687.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15687
----
commit ebb6e3200bbe9c725100048fc30f898a7f64c8b5
Author: Maria Rydzy <majrydzy...@gmail.com>
Date: 2016-10-30T13:50:38Z
Update SparkPi.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
