Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15677
The argument would be: because it's not less-right? (I'm not even judging
whether your points are right but I presume they are.)
I think we did originally not have nearly this much change regarding types
and I wanted to merge the last PR, so yes I had the same question before. But
we're here now, so what's the simplest path forward?
The review has been dragging on, which is OK if it's converging, but now
you're suggesting you want to abandon this change. I don't think that's the
right outcome. I'd rather resolve the stall by breaking down the change
instead. I don't hear that you're arguing that the docs are wrong, just as
incomplete in some ways as they were before.
More practically, it's hard for you to ask for a hundred changes in
comments. It's hard for me to track whether the changes affect what I've
previously reviewed. I think we have to draw this to a checkpoint and so I'm
asking the narrower question, whether this is actually making anything worse?
it makes a number of different things better, according to its original purpose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
