GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/15690
[SPARK-18174] [SQL] Avoid Implicit Type Cast in Arguments of Expressions
Extending String2StringExpression
### What changes were proposed in this pull request?
For the expressions that extend `String2StringExpression` (including,
`lower`, `upper`, `ltrim`, `rtrim`, `trim` and `reverse`), `Analyzer` should
not implicitly cast the arguments to string. Instead, if users input the some
data types instead of string, we should issue an exception for this misuse.
### How was this patch tested?
Added a test case in the `StringFunctionsSuite`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark string2string
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15690
----
commit a2c6d4e06a11350a9ab8493fc1cd5ef5750c3c77
Author: gatorsmile <gatorsm...@gmail.com>
Date: 2016-10-30T19:02:49Z
fix.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
