Github user windpiger commented on the issue:

    https://github.com/apache/spark/pull/15668
  
    @hvanhovell @cloud-fan  Do you mean that just change 
distinctAggChildren/regularAggChildren to represent the unfoldable expressions, 
and then the followings code could be unchanged? 
    
    ...
    val distinctAggChildren = 
distinctAggGroups.keySet.flatten.toSeq.distinct.**filter(!_.foldable)**
    ...
    
    val regularAggChildren = 
regularAggExprs.flatMap(\_.aggregateFunction.children).distinct.**filter(!_.foldable)**



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to