GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/15694
[SPARK-18179][SQL] Throws analysis exception with a proper message for
unsupported argument types in reflect/java_method function
## What changes were proposed in this pull request?
This PR proposes throwing an `AnalysisException` with a proper message
rather than `NoSuchElementException` with the message ` key not found:
TimestampType` when unsupported types are given to `reflect` and `java_method`
functions.
This PR also adds some more tests related with exceptions when method or
class is not found.
```scala
spark.range(1).selectExpr("reflect('java.lang.String', 'valueOf',
cast('1990-01-01' as timestamp))")
```
produces
**Before**
```
java.util.NoSuchElementException: key not found: TimestampType
at scala.collection.MapLike$class.default(MapLike.scala:228)
at scala.collection.AbstractMap.default(Map.scala:59)
at scala.collection.MapLike$class.apply(MapLike.scala:141)
at scala.collection.AbstractMap.apply(Map.scala:59)
at
org.apache.spark.sql.catalyst.expressions.CallMethodViaReflection$$anonfun$findMethod$1$$anonfun$apply$1.apply(CallMethodViaReflection.scala:159)
...
```
**After**
```
cannot resolve 'reflect('java.lang.String', 'valueOf', CAST('1990-01-01' AS
TIMESTAMP))' due to data type mismatch: arguments from the third require
boolean, byte, short, integer, long, float, double or string expressions; line
1 pos 0;
'Project [unresolvedalias(reflect(java.lang.String, valueOf,
cast(1990-01-01 as timestamp)), Some(<function1>))]
+- Range (0, 1, step=1, splits=Some(2))
...
```
Added message is,
```
arguments from the third require boolean, byte, short, integer, long,
float, double or string expressions
```
## How was this patch tested?
Tests added in `MiscFunctionsSuite`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-18179
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15694.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15694
----
commit edb5d7f6598332bdd99e905f39cfef06e93b8fe6
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-10-31T14:44:17Z
Throws analysis exception with a proper message for unsupported argument
types in reflect/java_method function
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
