Github user jkbradley commented on the issue:

    https://github.com/apache/spark/pull/15413
  
    As far as keeping the code around, I much prefer either the current 
approach (separate code) or having spark.mllib call into spark.ml.  That will 
make it easier to deprecate and eventually remove spark.mllib code in 3.0.
    
    I like the upper-triangular matrix packing and unpacking!  Could you please 
add a unit test for it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to