Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15691#discussion_r85890813
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -30,37 +30,185 @@ import org.apache.spark.unsafe.types.CalendarInterval
class TypeCoercionSuite extends PlanTest {
- test("eligible implicit type cast") {
- def shouldCast(from: DataType, to: AbstractDataType, expected:
DataType): Unit = {
- val got =
TypeCoercion.ImplicitTypeCasts.implicitCast(Literal.create(null, from), to)
- assert(got.map(_.dataType) == Option(expected),
- s"Failed to cast $from to $to")
+ private def shouldCast(from: DataType, to: AbstractDataType, expected:
DataType): Unit = {
+ val got =
TypeCoercion.ImplicitTypeCasts.implicitCast(Literal.create(null, from), to)
--- End diff --
I wanna point out that, `ImplicitTypeCasts` is not the only rule which will
cast data type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
