Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15688#discussion_r86007181
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
 ---
    @@ -471,11 +471,30 @@ class InMemoryCatalog(
           table: String,
           partialSpec: Option[TablePartitionSpec] = None): 
Seq[CatalogTablePartition] = synchronized {
         requireTableExists(db, table)
    -    if (partialSpec.nonEmpty) {
    -      throw new UnsupportedOperationException(
    -        "listPartition with partial partition spec is not implemented")
    +
    +    partialSpec match {
    +      case None => catalog(db).tables(table).partitions.values.toSeq
    +      case Some(partial) =>
    +        if (partial.size == getTable(db, 
table).partitionColumnNames.length) {
    +          val matchedPartition = 
catalog(db).tables(table).partitions.get(partial)
    +          Seq(matchedPartition.getOrElse {
    +            val specString = partial.map { case (k, v) => s"$k=$v" 
}.mkString("{", ", ", "}")
    +            throw new AnalysisException("Partition not found: " + 
specString)
    +          })
    +        } else {
    +          catalog(db).tables(table).partitions.toSeq.collect {
    +            case (spec, partition) if isPartialPartitionSpec(partial, 
spec) => partition
    +          }
    +        }
    +    }
    +  }
    +
    +  private def isPartialPartitionSpec(
    --- End diff --
    
    we should document it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to