Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15677#discussion_r86062599 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -898,8 +995,12 @@ case class ToUTCTimestamp(left: Expression, right: Expression) * Returns the date part of a timestamp or string. */ @ExpressionDescription( - usage = "_FUNC_(expr) - Extracts the date part of the date or datetime expression expr.", - extended = "> SELECT _FUNC_('2009-07-30 04:17:52');\n '2009-07-30'") + usage = "_FUNC_(date) - Extracts the date part of the date or timestamp expression.", --- End diff -- Hm, primarily this takes `DateType` with implicit conversion. I understand, In practical, it is right to say other data types as it basically casts but in that case we should mention something like `string expression` too. I do hope we can improve this when describing arguments too. (we may have to make it from `date` to something like `date/timestamp/string`).
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org