Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15644#discussion_r86077923
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
    @@ -282,6 +316,114 @@ class TaskSchedulerImplSuite extends SparkFunSuite 
with LocalSparkContext with B
         assert(!failedTaskSet)
       }
     
    +  test("scheduled tasks obey task and stage blacklists") {
    --- End diff --
    
    sure.  to be honest, I'm not sure how much it helps -- pulling out the 
common setup makes it a bit harder to trace what is going on, IMO.  but I also 
don't feel strongly.  Its the last commit so you can see it both ways:
    
    
https://github.com/apache/spark/pull/15644/commits/6a026341de96c67218d18421a69a780a04994112


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to