Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r86218960
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,36 @@ package org.apache.spark.sql.execution.streaming
* ordering of two [[Offset]] instances. We do assume that if two offsets
are `equal` then no
* new data has arrived.
*/
-trait Offset extends Serializable {}
+abstract class Offset {
--- End diff --
nit: could you document that we only compare the json string, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
