Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/15702#discussion_r86252932
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -437,6 +441,22 @@ class StreamExecution(
sink.addBatch(currentBatchId, nextBatch)
reportNumRows(executedPlan, triggerLogicalPlan, newData)
+ // Update the eventTime watermark if we find one in the plan.
+ // TODO: Does this need to be an AttributeMap?
+ lastExecution.executedPlan.collect {
+ case e: EventTimeWatermarkExec =>
+ logTrace(s"Maximum observed eventTime: ${e.maxEventTime.value}")
+ (e.maxEventTime.value / 1000) - e.delay.milliseconds()
+ }.headOption.foreach { newWatermark =>
+ if (newWatermark > currentEventTimeWatermark) {
+ logInfo(s"Updating eventTime watermark to: $newWatermark ms")
+ streamMetrics.reportTriggerDetail(EVENT_TIME_WATERMARK,
newWatermark)
--- End diff --
I think thats okay?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
