Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/11105#discussion_r84380686
--- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala ---
@@ -136,15 +179,76 @@ abstract class AccumulatorV2[IN, OUT] extends
Serializable {
def reset(): Unit
/**
+ * Takes the inputs and accumulates. e.g. it can be a simple `+=` for
counter accumulator.
+ * Developers should extend addImpl to customize the adding
functionality.
+ */
+ final def add(v: IN): Unit = {
+ if (metadata != null && metadata.dataProperty) {
+ dataPropertyAdd(v)
+ } else {
+ addImpl(v)
+ }
+ }
+
+ private def dataPropertyAdd(v: IN): Unit = {
+ // Add first for localValue & AccumulatorInfo
--- End diff --
sorry I wasn't clear -- I meant why is "first" important. But i guess
first isn't actually important, you're saying that *both* are needed. Can you
update the comment to reflect that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
